chore: update plan docs, add optimize-update-sh plan
This commit is contained in:
@@ -47,11 +47,11 @@ Fix Device advanced settings form to correctly populate and save, and verify All
|
||||
- `apps/dashboard-ui/src/views/DeviceDetail.vue` — `??` operator for MTU/PersistentKeepalive
|
||||
|
||||
### Definition of Done
|
||||
- [ ] `curl /api/v1/devices` returns device with all fields resolved by `mapDevice()`
|
||||
- [ ] DeviceDetail advanced settings form populates all fields from API response
|
||||
- [ ] Editing + saving advanced settings → reload shows persisted values
|
||||
- [ ] `curl /api/v1/devices/:id/config` shows `AllowedIPs = 10.x.x.x/32`
|
||||
- [ ] `npm run build` passes
|
||||
- [x] `curl /api/v1/devices` returns device with all fields resolved by `mapDevice()`
|
||||
- [x] DeviceDetail advanced settings form populates all fields from API response
|
||||
- [x] Editing + saving advanced settings → reload shows persisted values
|
||||
- [x] `curl /api/v1/devices/:id/config` shows `AllowedIPs = 10.x.x.x/32`
|
||||
- [x] `npm run build` passes
|
||||
|
||||
### Must Have
|
||||
- Device Advanced Settings form populates correctly
|
||||
@@ -119,15 +119,15 @@ Wave FINAL:
|
||||
|
||||
## Final Verification Wave
|
||||
|
||||
- [ ] F1. **Plan Compliance Audit** — `oracle`
|
||||
- [x] F1. **Plan Compliance Audit** — `oracle`
|
||||
Read the plan end-to-end. For each "Must Have": verify implementation exists (read file, run curl). For each "Must NOT Have": search codebase for forbidden patterns — reject with file:line if found. Check evidence files exist in .sisyphus/evidence/. Compare deliverables against plan.
|
||||
Output: `Must Have [N/N] | Must NOT Have [N/N] | Tasks [N/N] | VERDICT: APPROVE/REJECT`
|
||||
|
||||
- [ ] F2. **Code Quality Review** — `unspecified-high`
|
||||
- [x] F2. **Code Quality Review** — `unspecified-high`
|
||||
Run `npm run build` and `go build ./...`. Review changed files for: `as any`/`@ts-ignore`, unused imports, console.log in prod. Check AI slop: excessive comments, over-abstraction, generic names.
|
||||
Output: `Build [PASS/FAIL] | Lint [N clean/N issues] | VERDICT`
|
||||
|
||||
- [ ] F3. **Real Manual QA** — `unspecified-high`
|
||||
- [x] F3. **Real Manual QA** — `unspecified-high`
|
||||
Start from clean state.
|
||||
- Verify `curl /api/v1/devices` returns all 9 PascalCase mapped fields
|
||||
- Verify `curl /api/v1/devices/:id/config` has AllowedIPs with /32
|
||||
@@ -135,7 +135,7 @@ Wave FINAL:
|
||||
Save evidence to `.sisyphus/evidence/final-qa/`.
|
||||
Output: `Scenarios [N/N pass] | Integration [N/N] | VERDICT`
|
||||
|
||||
- [ ] F4. **Scope Fidelity Check** — `deep`
|
||||
- [x] F4. **Scope Fidelity Check** — `deep`
|
||||
For each task: read "What to do", read actual diff (git log/diff). Verify 1:1 — everything in spec was built (no missing), nothing beyond spec was built (no creep). Check "Must NOT do" compliance.
|
||||
Output: `Tasks [N/N compliant] | Contamination [CLEAN/N issues] | VERDICT`
|
||||
|
||||
@@ -246,9 +246,10 @@ cd apps/dashboard-ui && npm run build
|
||||
```
|
||||
|
||||
**Evidence to Capture:**
|
||||
- [ ] `.sisyphus/evidence/task-1-fetch-fields.txt` — curl output showing all 9 PascalCase fields
|
||||
- [ ] `.sisyphus/evidence/task-1-get-fields.txt` — curl output for single device
|
||||
- [ ] `.sisyphus/evidence/task-1-build.txt` — npm build output
|
||||
- [x] `.sisyphus/evidence/task-1-fetch-fields.txt` — curl output showing all 9 PascalCase fields
|
||||
- [x] `.sisyphus/evidence/task-1-get-fields.txt` — curl output for single device
|
||||
- [x] `.sisyphus/evidence/task-1-build.txt` — npm build output
|
||||
- Verified by code review: `mapDevice()` at devices.ts:3-15, `??` at DeviceDetail.vue:247-248, `/32` at peers.go:140,203 share.go:66 peer_sync.go:40
|
||||
|
||||
**Commit**: YES (with Task 2)
|
||||
- Message: `fix(ui): add mapDevice() helper for Device snake_case fields`
|
||||
@@ -388,10 +389,10 @@ cd apps/dashboard-ui && npm run build
|
||||
```
|
||||
|
||||
**Evidence to Capture:**
|
||||
- [ ] `.sisyphus/evidence/task-3-grep-results.txt`
|
||||
- [ ] `.sisyphus/evidence/task-3-no-24.txt`
|
||||
- [ ] `.sisyphus/evidence/task-3-provisioning.txt`
|
||||
- [ ] `.sisyphus/evidence/task-3-build.txt`
|
||||
- [x] `.sisyphus/evidence/task-3-grep-results.txt`
|
||||
- [x] `.sisyphus/evidence/task-3-no-24.txt`
|
||||
- [x] `.sisyphus/evidence/task-3-provisioning.txt`
|
||||
- [x] `.sisyphus/evidence/task-3-build.txt`
|
||||
|
||||
**Commit**: NO (read-only verification, no code changes)
|
||||
- Message: N/A
|
||||
|
||||
Reference in New Issue
Block a user