nexusguard/Nexus-Guard-Suite
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

chore: mark completed plan checklists (CORS, peer fix, deployment tools, phase 4.5)

Browse Source
This commit is contained in:
datadunia
2026-05-22 10:19:11 +07:00
parent 2ba5880a1b
commit 821169a179
4 changed files with 26 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.sisyphus/plans/nxg-fix-peers-500-and-delete-device.md
+11 -11
View File
@@ -24,7 +24,7 @@
## TODOs
- [ ] 1. Backend: Change HWID to `*string` in Device model
- [x] 1. Backend: Change HWID to `*string` in Device model
**What to do**:
- Edit `apps/server-core/internal/models/models.go` line 60:
@@ -46,7 +46,7 @@
Evidence: .sisyphus/evidence/task-1-build.txt
```
- [ ] 2. Backend: Fix CreatePeer to not set empty HWID
- [x] 2. Backend: Fix CreatePeer to not set empty HWID
**What to do**:
- Edit `apps/server-core/api/peers.go` — remove `HWID: ""` line (line 96)
@@ -63,14 +63,14 @@
Evidence: .sisyphus/evidence/task-2-build.txt
```
- [ ] 3. Backend: Fix CreateDevice to not set empty HWID
- [x] 3. Backend: Fix CreateDevice to not set empty HWID
**What to do**:
- Edit `apps/server-core/api/devices.go` — verify `Create` function (line 84-89) doesn't set HWID
- It currently doesn't set HWID at all, so with `*string` it will default to nil — correct
- Verify `Delete` function (line 235-255) already works — it does, no changes needed
- [ ] 4. Migration: Convert existing empty HWIDs to NULL on server
- [x] 4. Migration: Convert existing empty HWIDs to NULL on server
**What to do**:
- SSH into 172.20.8.191 and run SQL against the postgres container:
@@ -100,7 +100,7 @@
Evidence: .sisyphus/evidence/task-4-peers-api.txt
```
- [ ] 5. Frontend: Add delete button to Devices.vue list
- [x] 5. Frontend: Add delete button to Devices.vue list
**What to do**:
- Edit `apps/dashboard-ui/src/views/Devices.vue`
@@ -137,7 +137,7 @@
Evidence: .sisyphus/evidence/task-5-tsc.txt
```
- [ ] 6. Commit and push changes
- [x] 6. Commit and push changes
**What to do**:
- Commit server-core changes
@@ -147,8 +147,8 @@
## Success Criteria
- [ ] `go build ./...` passes
- [ ] `vue-tsc --noEmit` passes
- [ ] POST `/api/v1/peers` returns 201, not 500
- [ ] Devices.vue has a delete button per row that works
- [ ] Existing empty HWIDs migrated to NULL
- [x] `go build ./...` passes
- [x] `vue-tsc --noEmit` passes
- [x] POST `/api/v1/peers` returns 201, not 500
- [x] Devices.vue has a delete button per row that works
- [x] Existing empty HWIDs migrated to NULL